Update analytics ecommerce event and param types #2728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
reviewed
Mar 24, 2020
| @@ -4477,6 +4526,14 @@ declare namespace firebase.analytics { | |||
| value?: number; | |||
| event_label?: string; | |||
| event_category: string; | |||
| shipping_tier?: string; | |||
There was a problem hiding this comment.
The proposal only adds the following:
// New suggested event parameters.
shipping_tier?: string;
item_list?: string;
item_list_id?: string;
payment_type?: string;
Where are the other ones defined?
There was a problem hiding this comment.
item_list is not present in the sheet. I think it has been replaced by item_list_name, see comment.
egilmorez
reviewed
Mar 24, 2020
egilmorez
reviewed
Mar 24, 2020
Binary Size ReportAffected SDKs
Test Logs |
egilmorez
approved these changes
Mar 24, 2020
Feiyang1
suggested changes
Mar 24, 2020
| @@ -4477,6 +4526,14 @@ declare namespace firebase.analytics { | |||
| value?: number; | |||
| event_label?: string; | |||
| event_category: string; | |||
| shipping_tier?: string; | |||
There was a problem hiding this comment.
item_list is not present in the sheet. I think it has been replaced by item_list_name, see comment.
Feiyang1
approved these changes
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Analytics types and method signatures to reflect GA's enhanced ecommerce options.
The latter should only affect IDE autocomplete. All event params are always optional and any additional arbitrary param is always allowed.
This changes the public API and will require a documentation update.
Internal bug for this feature: b/151107871